Eliminate force unwraps, extract chart hover helper, optimize token sort#109
Merged
KyleNesium merged 1 commit intomainfrom Mar 14, 2026
Merged
Eliminate force unwraps, extract chart hover helper, optimize token sort#109KyleNesium merged 1 commit intomainfrom
KyleNesium merged 1 commit intomainfrom
Conversation
…ze token sort - Replace force unwraps in UsageSnapshot.interpolate() and autoResolvedMode with safe access (guard-let, optional chaining) to prevent potential crashes - Extract shared chartHoverOverlay() helper in ActivityChartView, eliminating 3× duplicated GeometryReader + Rectangle + onContinuousHover boilerplate - Replace sortedTokens (copies + mutates array every render) with orderedTokens that builds iteration order without modifying the source array - Add clarifying comment on ModelPricing linear scan (6 entries, already cached)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UsageSnapshot.interpolate()andautoResolvedModewith safe access — prevents potential crashes on empty/unexpected datachartHoverOverlay()in ActivityChartView — eliminates 3× duplicated GeometryReader + Rectangle + onContinuousHover boilerplate across daily/hourly/monthly chartssortedTokens(copies + mutates array every render) withorderedTokensthat builds iteration order without modifying the source arrayTest plan