Extract chart trend logic and split StatusBarManager.updateButton#110
Merged
KyleNesium merged 1 commit intomainfrom Mar 14, 2026
Merged
Extract chart trend logic and split StatusBarManager.updateButton#110KyleNesium merged 1 commit intomainfrom
KyleNesium merged 1 commit intomainfrom
Conversation
…ed methods - Extract ~150 lines of trend computation from ActivityChartView (678→526 lines) into ActivityChartTrend.swift: ActivityTrendComputation enum with pure comparison logic (vs yesterday, vs last week, vs last month) and shared formatting helpers - Split StatusBarManager.updateButton (81 lines) into 6 focused methods: resolveMetricMode, resolveStarColor, updateSparkleState, updateRenderState, updateBreathTimer, resolveDisplayText — each under 10 lines - Make compactCount and formatHourLabel internal for cross-file access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActivityChartTrend.swift— pure comparison logic and shared formatting helpersStatusBarManager.updateButton(81 lines) into 6 focused methods, each under 10 linescompactCountandformatHourLabelinternal for cross-file accessTest plan