Replace rest with graphql for theme level support#360
Open
enmaboya wants to merge 13 commits intoKyon147:masterfrom
Open
Replace rest with graphql for theme level support#360enmaboya wants to merge 13 commits intoKyon147:masterfrom
enmaboya wants to merge 13 commits intoKyon147:masterfrom
Conversation
|
VerifyScopes middleware + ApiHelper from Services is also using REST API for activateCharge, createCharge and createUsageCharge |
Owner
|
@enmaboya I am going to get this tested and deployed next week. |
Kyon147
previously approved these changes
Mar 25, 2025
Owner
|
@enmaboya can you just take a quick look at the conflicts and I will get this merged in to go with the next major release. |
…shopify; branch 'master' of github.com:Kyon147/laravel-shopify
enmaboya
force-pushed
the
replace_rest_with_graphql_for_theme_level_support
branch
from
ee894b2 to
917cb23
Compare
enmaboya
force-pushed
the
replace_rest_with_graphql_for_theme_level_support
branch
from
41dd5b5 to
f145bc2
Compare
Contributor
Author
|
@Kyon147 Conflicts resolved. |
|
@Kyon147 can you merge this ? |
enmaboya
force-pushed
the
replace_rest_with_graphql_for_theme_level_support
branch
4 times, most recently
from
d23ceb9 to
65f4e98
Compare
…_graphql_for_theme_level_support
enmaboya
force-pushed
the
replace_rest_with_graphql_for_theme_level_support
branch
from
65f4e98 to
6ec7f20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for switching from REST to GraphQL is the same as with access scopes. REST is deprecated. Additionally, REST is redundant; it retrieves too much data, making it roughly three times slower than GraphQL in this case. Moreover, I strongly doubt that the theme helper service was used by anyone or anywhere outside the package.