Upgrade PHP requirement: 8.0 → 8.1, code adjustments #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enmaboya
force-pushed
the
chore/bump-php-min-8.1
branch
4 times, most recently
from
9288d5a to
82e2977
Compare
enmaboya
force-pushed
the
chore/bump-php-min-8.1
branch
from
82e2977 to
2aab761
Compare
enmaboya
force-pushed
the
chore/bump-php-min-8.1
branch
3 times, most recently
from
7e91eec to
3d62c02
Compare
enmaboya
force-pushed
the
chore/bump-php-min-8.1
branch
from
3d62c02 to
1f0a5b6
Compare
Kyon147
reviewed
Jul 16, 2025
| parameters: | ||
| ignoreErrors: | ||
| - | ||
| message: '#^Deprecated in PHP 8\.4\: Parameter \#1 \$session \(Gnikyt\\BasicShopifyAPI\\Session\) is implicitly nullable via default value null\.$#' |
There was a problem hiding this comment.
I am thinking, these errors will need to be fixed eventually, as 8.1 / 8.2 won't be support for a lot longer so we will need to move over the 8.3 but might be worth just jumping to 8.4 when that refactor happens.
This would mean bringing in our own API package I think. Unless we can use something Shopify already has but I've not looked.
Thoughts @enmaboya
There was a problem hiding this comment.
@Kyon147 Fork of the package is currently on hold due to work commitments. However, I expect to publish it soon with fixes for the issues flagged by PHPStan and a minimum PHP version of 8.1 (with further updates planned in the future).
Kyon147
approved these changes
Jul 16, 2025
Kyon147
added
PR: Approved
Release: Major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for changing the minimum version: