Open
Conversation
A best of 3 of best of 3s. There's a lot of scores to keep track of, I tried my best to structure data in a nice way.
One of the in-depth graphics systems, due to the amount of screen time the holding card will get (holding card not included)
Holding card still not included
Member
benjaminkay93
left a comment
benjaminkay93
left a comment
There was a problem hiding this comment.
Looks good however not at a windows PC to run with casper to check things are happy, but if no one else gets a look in ill be able to have a check tomorrow night
stephenrob
requested changes
Apr 5, 2018
Member
stephenrob
left a comment
stephenrob
left a comment
There was a problem hiding this comment.
There's a few minor changes to make due to conflicts @benjaminkay93 and need to confirm these are the exact e-sports being played this year.
Ideally this should be made an editable list of Games - i.e Text box for game 1, 2 & 3 that is then referenced everywhere else.
If this can be re-based onto master to fix the conflicts that would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.