Skip to content

FT-IOS App#66

Open
Brendajoshua wants to merge 3 commits intomasterfrom
FT-iosApp
Open

FT-IOS App#66
Brendajoshua wants to merge 3 commits intomasterfrom
FT-iosApp

Conversation

@Brendajoshua
Copy link
Copy Markdown
Collaborator

Description

Add attribution link to Readme and code

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

Please describe steps taken to ensure this feature is functional and does not break other features:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if relevant
  • I have run the app using my feature and ensured that no functionality is broken
  • My changes generate no new warnings
  • There are no merge conflicts

@ghost
Copy link
Copy Markdown

ghost commented Jan 31, 2020

DeepCode's analysis on #b25171 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

"appName": "Artfunder",
"bundledWebRuntime": false,
"npmClient": "npm",
"webDir": "build",
Copy link
Copy Markdown
Collaborator

@PressureandTime PressureandTime Jan 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be www instead of build because capacitator will give problems otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants