Allow CLI overrides for runtime features#39
Merged
bvanessen merged 15 commits intoLBANN:mainfrom May 8, 2025
Merged
Conversation
was overwritten if multiple CLI options were provided. Added an override arguments CLI option to allow a user to override any existing center-provided default.
the runtime launch args.
bvanessen
force-pushed
the
feature_cli_override
branch
from
0a601e6 to
6e1f5c0
Compare
Added helper functions to customize per scheduler.
the scheduling parent class.
scheduler into the parent class. Added a CLI to provide a custom launch folder name.
arguments to the internal and launch commands.
Collaborator
Author
|
@tbennun This is ready now. |
batch launch commands. Fix some LSF bugs.
configuration by passing it with a leading tilde (~). Also corrected the unit testing for the new CLI override.
Collaborator
Author
|
@tbennun I have fixed up the unit testing. |
tbennun
requested changes
May 7, 2025
Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the parsing of key=value arguments where the dictonary
was overwritten if multiple CLI options were provided. Added an override arguments CLI option to allow a user to override any existing center-provided default.