a few fixes related to highscore notifications

ProjectLighthouse.Servers.GameServer/Controllers/Slots/ScoreController.cs

@@ -1,4 +1,4 @@
 #nullable enable
 using LBPUnion.ProjectLighthouse.Database;
 using LBPUnion.ProjectLighthouse.Extensions;
 using LBPUnion.ProjectLighthouse.Helpers;
@@ -25,7 +25,7 @@
 {
     private readonly DatabaseContext database;
 
     public ScoreController(DatabaseContext database)
     {
         this.database = database;
     }
@@ -34,7 +34,7 @@
     {
         UserFriendData? store = UserFriendStore.GetUserFriendData(userId);
         List<int>? friendIds = store?.FriendIds;
         friendIds ??= new List<int>();
         friendIds.Add(userId);
 
         return friendIds.Distinct().ToArray();
@@ -64,7 +64,7 @@
         // Workaround for parsing player ids of versus levels
         if (score.PlayerIds.Length == 1)
         {
             char[] delimiters = { ':', ',', };
             score.PlayerIds = score.PlayerIds[0].Split(delimiters).Distinct().ToArray();
         }
 
@@ -152,7 +152,9 @@
             this.database.Scores.Add(existingScore);
         }
 
-        if (score.Points > existingScore.Points)
+        bool personalBest = score.Points > existingScore.Points;
+
+        if (personalBest)
         {
             existingScore.Points = score.Points;
             existingScore.Timestamp = TimeHelper.TimestampMillis;
@@ -172,12 +174,14 @@
             TargetPlayerIds = null,
         });
 
-        if (score.Type == 1 && scores.YourRank == 1 && scores.Total > 1)
+        // if this is a PB, singleplayer, at the top of the leaderboard (not scores.YourRank==1 because it might be tied), and there is at least one other score,
+        // send a notification to the user with the previous highscore
+        if (personalBest && score.Type == 1 && scores.Scores[0].UserId == token.UserId && scores.Total > 1)
         {
             GameScore? second = scores.Scores[1];
             UserEntity? user = await this.database.UserFromGameToken(token);
 
-            await this.database.SendNotification(second.UserId, $"{user?.InfoXml} beat your highscore (<em>{second.Points}</em>) on {slot.InfoXml} with a score of <em>{score.Points}</em>.", true);
+            await this.database.SendNotification(second.UserId, $"{user?.InfoXml} beat your highscore (<em>{second.Points}</em>) on {slot.InfoXml} with a score of <em>{score.Points}</em>.", false);
         }
 
         return this.Ok(scores); 
@@ -202,7 +206,7 @@
         };
         if (!HttpMethods.IsPost(this.Request.Method))
         {
             List<PlayerScoreboardResponse> scoreboardResponses = new();
             for (int i = 1; i <= 4; i++)
             {
                 options.ScoreType = i;