Skip to content

Removes the deprecated absorption parameter#431

Merged
fakufaku merged 1 commit intomasterfrom
fix/remove_absorption_param_2
Apr 6, 2026
Merged

Removes the deprecated absorption parameter#431
fakufaku merged 1 commit intomasterfrom
fix/remove_absorption_param_2

Conversation

@fakufaku
Copy link
Copy Markdown
Collaborator

@fakufaku fakufaku commented Apr 6, 2026

Removes the deprecated absorption parameter from ShoeBox, Room.from_corners, and Room.extrude.

Thanks for sending a pull request (PR), we really appreciate that! Before hitting the submit button, we'd be really glad if you could make sure all the following points have been cleared.

Please also refer to the doc on contributing for more details. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

@fakufaku fakufaku force-pushed the fix/remove_absorption_param_2 branch from 39f04c7 to 4b7489f Compare April 6, 2026 15:18
@fakufaku fakufaku merged commit c7365b8 into master Apr 6, 2026
10 checks passed
@fakufaku fakufaku deleted the fix/remove_absorption_param_2 branch April 6, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant