Skip to content

670 need mpc codes for new elp 0m4s#672

Open
talister wants to merge 11 commits intomainfrom
670-need-mpc-codes-for-new-elp-0m4s
Open

670 need mpc codes for new elp 0m4s#672
talister wants to merge 11 commits intomainfrom
670-need-mpc-codes-for-new-elp-0m4s

Conversation

@talister
Copy link
Member

@talister talister commented Mar 9, 2026

This PR is mostly focused on adding the new MPC site codes for the "new" ELP 0.4m's. Changes:

  • Adds site positions for the 2 telescopes
  • Adds the 2 new codes into the various sets/lists
  • Update telescope and detector strings for Delta Rho + QHY600 telescope + camera (Reported by @carrholt)

Also other minor updates:

  • Specify and allow minimum elevation for the JPL SBObs frontend, which eliminates the non-visible objects previously returned (The default min_elev specified in the JPL API docs doesn't seem to be actually applied)
  • Fix neox/tests/base.by for removal of Numpy long which was breaking all the functional tests

talister added 11 commits January 6, 2026 12:31
@talister
Add new fake MPC codes for new ELP aqwb 0m4's. Rev version number to …
3ef0b42 
…3.17.1a(lpha)
@talister
Fix missing comma that was causing elp-aqwb-0m4b/V99 to be configured…
427f014 
… as a 1m+Sinistro. Add moar tests
@talister
Add support for additional constraints (==, !=, is defined, not defined)
fb8b2c7
@talister
Add ability to pass a minimum altitude with default of 30deg
bbc59c4
@talister
Update tests for elev-min. Rename min_alt parameter to min_elev to be…
5b6ed09 
…tter match the sbobs parameter
@talister
numpy.long is long gone (Ba..dum...tiss...)
ffe2c47
@talister
Update for received MPC code for elp-aqwb-0m4a. Update positions for …
fcf1bb5 
…both elp-aqwb-0m4a and -0m4b.
@talister
Complete update for new ELP MPC codes (Fixes #670)
3570652
@talister
Add ssl_verify parameters to the mocks for mock_fetchpage_and_make_so…
25a5281 
…up()
@talister
Fix for slight changes in expected magnitude due to changes in the JP…
96ec05e 
…L M1,k1
@talister
Update changelog and version number
02e7e3b
@talister talister requested a review from carrholt March 9, 2026 22:17
@talister talister self-assigned this Mar 9, 2026
@talister talister linked an issue Mar 9, 2026 that may be closed by this pull request
Need MPC codes for new ELP 0m4's #670
Open
12 tasks
carrholt
carrholt approved these changes Mar 10, 2026
View reviewed changes
Copy link
Contributor

@carrholt carrholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carrholt carrholt carrholt approved these changes

Assignees

@talister talister

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need MPC codes for new ELP 0m4's

2 participants

@talister @carrholt