Skip to content

Update bf_work.py bf class for Primary Contribution #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kallimathios wants to merge 1 commit into from
Closed

Update bf_work.py bf class for Primary Contribution #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ils_middleware/tasks/folio/mappings/bf_work.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
WHERE {{
<{bf_work}> a bf:Work .
<{bf_work}> bf:contribution ?contrib_bnode .
?contrib_bnode a bf:Contribution .
?contrib_bnode a bf:PrimaryContribution .
Copy link
Contributor

@jermnelson jermnelson Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on PR.

Copy link
Collaborator

@NancyL NancyL Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be preferable to have both bf:PrimaryContribution and bf:Contribution. And if possible, bf:PrimaryContribution should be marked as "primary".

Copy link
Collaborator Author

@kallimathios kallimathios Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, both. I would like to close this PR request and create a new one. Looking more closely at my checklist in #203, I think that this PR is slightly off. We will have both PrimaryContribution and Contribution.

?contrib_bnode bf:role ?role_uri .
?role_uri rdfs:label ?role .
?contrib_bnode bf:agent ?agent_uri .
Expand Down