Skip to content

iss1954 Track ID fixes in OverlayProducer#1963

Draft
oscarplewis wants to merge 5 commits intotrunkfrom
1954-fix-track-id-for-overlay
Draft

iss1954 Track ID fixes in OverlayProducer#1963
oscarplewis wants to merge 5 commits intotrunkfrom
1954-fix-track-id-for-overlay

Conversation

@oscarplewis
Copy link
Contributor

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1954 by incrementing all track IDs in the overlay sample by a hardcoded value set high enough to avoid interference with the simulated track IDs from the main sample. It also introduces logic to add SimCalorimeterHit contributors in full to all hits in the Ecal (where hit contributors are used), and makes the default sim collections to overlay all of the sim collections. (Though in a later update to this draft I'm going to fix this to accomodate the "scoring planes minimal" setting in the simulator detectors.)

Check List

  • I successfully compiled ldmx-sw with my developments.
  • I read, understood and follow the coding rules.
  • I ran my developments and the following shows that they are successful.

@oscarplewis oscarplewis linked an issue Feb 13, 2026 that may be closed by this pull request
@oscarplewis
Copy link
Contributor Author

oscarplewis commented Feb 13, 2026

Right now the track IDs are all incremented by 100,000, since I figured that would be surpass any real track IDs from the main sample. Future iterations of this workflow with three or more electrons (if we go in that direction) could go up to 200,000, etc. I also considered iterating through all track IDs present in the main sample to find the largest value and incrementing all the overlay track IDs by this value, but the fixed power of ten approach seemed simpler. Any thoughts would be welcome.

Also, there's two commits here duplicated in another PR. I'll rebase before submitting both so the history doesn't get fouled up, but this is the reason for the shocking number of edited files here (they're all small edits, changing hardcoded references to scoring plane and sim particles collections to configurable ones).

@tvami tvami requested a review from bryngemark February 13, 2026 06:16
@oscarplewis oscarplewis self-assigned this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix track ID for Overlay

1 participant