Add keccak256 hash algo to the SMT implementation with configurability#177
Merged
jimthematrix merged 5 commits intomainfrom Dec 10, 2025
Merged
Add keccak256 hash algo to the SMT implementation with configurability#177jimthematrix merged 5 commits intomainfrom
jimthematrix merged 5 commits intomainfrom
Conversation
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Chengxuan
reviewed
Dec 10, 2025
Comment on lines
+24
to
+34
| jsonObj := map[string]interface{}{ | ||
| "proof": proofStruct, | ||
| } | ||
| proofJSONBytes, _ := json.Marshal(jsonObj) | ||
|
|
||
| // Create the ABI type with explicit components using shared function | ||
| proofType := createProofType() | ||
|
|
||
| // Use abi.Arguments to pack the data | ||
| arguments := abi.Arguments{abi.Argument{Type: proofType}} | ||
| proofBytes, err := arguments.Pack(proofStruct) | ||
| arguments := abi.ParameterArray{proofType} | ||
| proofBytes, err := arguments.EncodeABIDataJSON(proofJSONBytes) |
Contributor
There was a problem hiding this comment.
these are just swapping ABI libs here 👍
Contributor
Author
There was a problem hiding this comment.
The above was so that the go-ethereum dependencies only exist for the e2e tests.
Chengxuan
approved these changes
Dec 10, 2025
Contributor
Chengxuan
left a comment
Chengxuan
left a comment
There was a problem hiding this comment.
Extending the interface to allow plug-able hasher looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See iden3/contracts#402 for details.
This is API breaking. It should be OK given we are pre-v1.0.