Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 83.66% 83.96% +0.30%
==========================================
Files 18 18
Lines 1114 1129 +15
==========================================
+ Hits 932 948 +16
+ Misses 182 181 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdunn314
left a comment
There was a problem hiding this comment.
Looks pretty good, but the issue is that we can and sometimes do use several different check sources of the same nuclide. For example, we use both a Na22 source with an activity of 9.98 uCi on Sep 29, 2023, and another one that is 1 uCi on Jan 2006. I think creating several subclasses of CheckSources for Na22, Mn54, Cs137, Co60, and Ba133 with their half-lives, photon energies, and intensities built in, but for which the user specifies the activity, name and activity date.
That makes sense to me. So instead of a subclass of CheckSource, we can create a class |
| name : | ||
| The name of the nuclide. | ||
| energy : | ||
| The energy of the gamma rays emitted by the nuclide. |
There was a problem hiding this comment.
The energy of the gamma rays emitted by the nuclide in keV
| energy : | ||
| The energy of the gamma rays emitted by the nuclide. | ||
| intensity : | ||
| The intensity of the gamma rays emitted by the nuclide. (must sum to 1) |
There was a problem hiding this comment.
Intensity doesn't need to sum to 1. For example, in Na22, 1.8 photons are emitted per decay due to positron annihilation creating two photons per beta+ particle being emitted.
There was a problem hiding this comment.
Ok good point thank you. It needs to be relative to something though no? i guess it's photon per decay?
cdunn314
left a comment
There was a problem hiding this comment.
Just a couple little edits in the doc string
This PR moves away from
get_decay_linesin favour of a class architecture for check sources.This will be useful in #71
TODO: