Conversation
XakerTwo
referenced
this pull request
Feb 17, 2025
When you put something in double quotes it will be passed as one parameter (one argv) to the program. This is a way to pass whitespace to programs. In our case the double quotes were wrong since we want to pass -G and the GUID (or -T and the timestamp) as seperate (argv) parameters. Now it builds with WinDRBD and the CAT files generated can be used to load the driver.
when target hardware id(-s) was not passed to `.sh` - fallback value is used however, during LINBIT#8 typo was introduced as a result - fallback value is in an incorrect and unused variable, while used variable remains empty
when several delimiters follows one by one with no data between one of them would be captured as part of the hwid or as a separate hwid for example, ",hwid1,hwid2,," would be parsed as ",hwid1" "hwid2" "," bug occurred due to missing update of hwid_begin
XakerTwo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- partial revert of d94ead3
- remove double OOM check (ace9bbf)
- fix typo in
.sh, that leads to incorrect.catfile (74c1009 and ef31458 are from parallel features, branched from f6a3c0f; 1st did not change problematic line, but 2nd did; there was conflict between them resolved as 5db4e1a)- fix bug in hwids parser on specific input; looks like i was aware of the root issue, but solve it not fully(correctly)