-
Notifications
You must be signed in to change notification settings - Fork 7
Feature/drel 817 migrate mcp from ipfc cids to npm pkg names #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FedericoAmura
wants to merge
42
commits into
main
Choose a base branch
from
feature/drel-817-migrate-mcp-from-ipfc-cids-to-npm-pkg-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,028
−686
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
41a20bc
feat: first implementation of mcp building based on npm pkgs
FedericoAmura 9cda182
feat: first implementation of mcp building based on npm pkgs - mcp sd…
FedericoAmura b24254d
feat: servers graceful shutdown, json and registry definitions consol…
FedericoAmura 4774cea
feat: deleted app or tool checks and not prod notification
FedericoAmura 3e8d8cf
fix: remove unused pkgs in mcp-sdk
FedericoAmura 10a1052
feat: use pnpm locally for tools pkg install but npm for out-in-the-w…
FedericoAmura 4ccb43a
feat: comment on require vs import
FedericoAmura b6f7368
Merge branch 'refs/heads/main' into feature/drel-817-migrate-mcp-from…
FedericoAmura c1e3897
fix: remove old version plan
FedericoAmura 8c16a12
feat: move tool pkgs installation to server start and away from first…
FedericoAmura a6d838a
fix: incorrect bundled vincent tool destructuring
FedericoAmura 2480c2c
fix: move which types dev dependency
FedericoAmura 72221c4
chore: code documentation
FedericoAmura 5ce2a6d
chore: doc and readme updates
FedericoAmura 1f620fd
chore: add release plan
FedericoAmura 74da7c6
feat: add descriptions exposed by tools
FedericoAmura e168934
Merge branch 'main' into feature/drel-817-migrate-mcp-from-ipfc-cids-…
FedericoAmura b374d76
Merge branch 'main' into feature/drel-817-migrate-mcp-from-ipfc-cids-…
FedericoAmura 2ec989c
fix: use once to call graceful shutdown function
FedericoAmura de34b8c
feat: convert parameters array in app def json into an object
FedericoAmura 1b1ea11
Merge branch 'refs/heads/main' into feature/drel-817-migrate-mcp-from…
FedericoAmura 6102180
feat: migrate from npm and pnpm to npx-import
FedericoAmura 5e70421
fix: move tools sdk as prod dep in mcp server
FedericoAmura 3a56bcb
Merge branch 'refs/heads/main' into feature/drel-817-migrate-mcp-from…
FedericoAmura bd08339
feat: use registry sdk and allow for version input as env variable
FedericoAmura 5bcd28f
feat: require mcp-sdk receives vincent bundled tools in its app defin…
FedericoAmura 577ecdb
feat: move tools sdk in mcp sdk to dev dep
FedericoAmura 4e84739
chore: update docs
FedericoAmura a5680f6
chore: comments updates
FedericoAmura eccf6ed
fix: set exitCode instead of forcefully exiting
FedericoAmura 5303ce0
feat: just warn and skip on registry deleted tools
FedericoAmura b298aeb
feat: app version enabled check
FedericoAmura 1a6d82f
feat: app tool in json file exists in registry
FedericoAmura c49d29f
feat: harden tool failure check
FedericoAmura bc57d89
fix: make tool params describe override non-mutative on the vincent tool
FedericoAmura 02d8822
fix: removed tools sdk from the wrong package json file
FedericoAmura 99e2d6d
feat: separate env verifications for stdio and http execution making …
FedericoAmura a9040ab
feat: migrate nonce and transport managers to node-cache
FedericoAmura 58d1109
Merge branch 'main' into feature/drel-817-migrate-mcp-from-ipfc-cids-…
FedericoAmura 5033694
chore: update lockfile
FedericoAmura 51f1340
feat: migrate to the registerTool syntax and add getters also as reso…
FedericoAmura 70d6bac
feat: close transport and nonce managers on http server cleanup
FedericoAmura File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| app-sdk: minor | ||
| mcp-sdk: major | ||
| mcp: major | ||
| --- | ||
|
|
||
| Migration of MCP building from JSON file exclusively to Registry based with json available for overrides |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it clear what the behaviour will be if you define a JSON file and an environment var, and they have different values? Does the JSON file override the .env, or the other way around? Or will the MCP server refuse to start because it can't be sure what to do?