Fix/deprecate alchemy for naga #1048
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Ethereum mainnet RPC URL used by the Lit Protocol's Naga network, replacing a deprecated Alchemy API endpoint with a new one.
- Replaces the deprecated
alchemyapi.iodomain with the currentalchemy.comdomain format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/constants/src/lib/constants/constants.ts | Updates Ethereum mainnet RPC URL from deprecated Alchemy endpoint to new endpoint |
| .changeset/nice-states-design.md | Adds changeset documenting the RPC URL update as a patch version change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type: 'ERC1155', | ||
| rpcUrls: [ | ||
| 'https://eth-mainnet.alchemyapi.io/v2/EuGnkVlzVoEkzdg0lpCarhm8YHOxWVxE', | ||
| 'https://eth-mainnet.g.alchemy.com/v2/_J7v1gEI40Tiulq7rFh913Xjy2-C4L8T', |
There was a problem hiding this comment.
Hardcoded API key in the RPC URL exposes sensitive credentials in this public repository. The Alchemy API key "_J7v1gEI40Tiulq7rFh913Xjy2-C4L8T" should not be committed to source control. Instead, this should be loaded from environment variables or configuration files that are not tracked by version control. Anyone with access to this repository can use this key, potentially leading to quota exhaustion or unauthorized usage charges.
| 'https://eth-mainnet.g.alchemy.com/v2/_J7v1gEI40Tiulq7rFh913Xjy2-C4L8T', | |
| 'https://cloudflare-eth.com', |
WHAT
Remove deprecated alchemy rpc url and replace it with a new one