Skip to content

Conversation

@FedericoAmura
Copy link
Contributor

Description

This PR removes bs58 from our dependencies and uses ethers to base58 encoding/decoding where it is needed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • "Bundle simplification"

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@FedericoAmura FedericoAmura self-assigned this Oct 1, 2024
@FedericoAmura FedericoAmura marked this pull request as ready for review October 1, 2024 14:12
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition from this PR! - I wonder how the bundle size differs with this change?

@Ansonhkg Ansonhkg added the ✨ Enhancement New feature or request label Oct 1, 2024
@FedericoAmura
Copy link
Contributor Author

Nice addition from this PR! - I wonder what's the bundle size differs with this change?

It might reduce our own codebase, but the full installed one I don't think so. bs58 is still a dependency for ens, sui and solana deps. So it will be bundled at least at the outer most packages

@Ansonhkg Ansonhkg merged commit 99ceb15 into staging/v7 Oct 2, 2024
3 checks passed
@Ansonhkg Ansonhkg deleted the feature/lit-3919-remove-bs58-from-the-bundle branch October 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants