Feature/lit 3918 no globalthis variables anymore

packages/access-control-conditions/README.md

@@ -7,12 +7,3 @@ This submodule provides functionalities for formatting and canonicalizing data,
 ```
 yarn add @lit-protocol/access-control-conditions
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/access-control-conditions-vanilla/access-control-conditions.js"></script>
-<script>
-  console.log(LitJsSdk_accessControlConditions);
-</script>
-```

packages/auth-browser/README.md

@@ -8,15 +8,6 @@ This submodule provides functionalities from various modules within the Lit SDK,
 yarn add @lit-protocol/auth-browser
 ```
 
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/auth-browser-vanilla/auth-browser.js"></script>
-<script>
-  console.log(LitJsSdk_authBrowser);
-</script>
-```
-
 ## Generate an authSig with long expiration
 
 ```

packages/auth-browser/src/lib/chains/eth.ts

@@ -7,7 +7,10 @@ import { toUtf8Bytes } from '@ethersproject/strings';
 
 // import WalletConnectProvider from '@walletconnect/ethereum-provider';
 import { verifyMessage } from '@ethersproject/wallet';
-import { EthereumProvider } from '@walletconnect/ethereum-provider';
+import {
+  EthereumProvider,
+  default as WalletConnectProvider,
+} from '@walletconnect/ethereum-provider';
 import { ethers } from 'ethers';
 import { getAddress } from 'ethers/lib/utils';
 import { SiweMessage } from 'siwe';
@@ -128,6 +131,8 @@ export type WALLET_ERROR_VALUES =
 
 /** ---------- Local Helpers ---------- */
 
+let litWCProvider: WalletConnectProvider | undefined;
+
 /**
  *
  * Convert chain hex id to chain name
@@ -386,8 +391,7 @@ export const connectWeb3 = async ({
     };
 
     if (isBrowser()) {
-      // @ts-ignore
-      globalThis.litWCProvider = wcProvider;
+      litWCProvider = wcProvider;
     }
   }
 
@@ -440,10 +444,9 @@ export const disconnectWeb3 = (): void => {
   }
 
   // @ts-ignore
-  if (isBrowser() && globalThis.litWCProvider) {
+  if (isBrowser() && litWCProvider) {
     try {
-      // @ts-ignore
-      globalThis.litWCProvider.disconnect();
+      litWCProvider.disconnect();
     } catch (err) {
       log(
         'Attempted to disconnect global WalletConnectProvider for lit-connect-modal',

packages/auth-helpers/README.md

@@ -7,12 +7,3 @@ This submodule manages permissions and capabilities related to accessing specifi
 ```
 yarn add @lit-protocol/auth-helpers
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/auth-helpers-vanilla/auth-helpers.js"></script>
-<script>
-  console.log(LitJsSdk_authHelpers);
-</script>
-```

packages/constants/README.md

@@ -7,12 +7,3 @@ This submodule exports various modules, constants, interfaces, errors, utilities
 ```
 yarn add @lit-protocol/constants
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/constants-vanilla/constants.js"></script>
-<script>
-  console.log(LitJsSdk_constants);
-</script>
-```

packages/contracts-sdk/README.md

@@ -6,22 +6,8 @@ Demo: https://demo-contracts-sdk-react.vercel.app/
 
 # Installation
 
-```js
-yarn add @lit-protocol/contracts-sdk
 ```
-
-# Vanilla JS (UMD)
-
-```html
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/contracts-sdk-vanilla/contracts-sdk.js"></script>
-<script>
-  (async () => {
-    const { LitContracts } = LitJsSdk_contractsSdk;
-
-    const litContracts = new LitContracts();
-    await litContracts.connect();
-  })();
-</script>
+yarn add @lit-protocol/contracts-sdk
 ```
 
 # Quick Start

packages/core/src/lib/lit-core.ts

@@ -50,6 +50,7 @@ import {
   logWithRequestId,
   mostCommonString,
   sendRequest,
+  setMiscLitConfig,
 } from '@lit-protocol/misc';
 import {
   AuthSig,
@@ -197,8 +198,8 @@ export class LitCore {
     // -- set bootstrapUrls to match the network litNetwork unless it's set to custom
     this.setCustomBootstrapUrls();
 
-    // -- set global variables
-    globalThis.litConfig = this.config;
+    // -- set misc global variables
+    setMiscLitConfig(this.config);
     bootstrapLogManager('core');
 
     // -- configure local storage if not present
@@ -387,7 +388,7 @@ export class LitCore {
 
     this._stopListeningForNewEpoch();
     // this._stopNetworkPolling();
-    if (globalThis.litConfig) delete globalThis.litConfig;
+    setMiscLitConfig(undefined);
   }
 
   // _stopNetworkPolling() {
@@ -532,9 +533,6 @@ export class LitCore {
     // this._scheduleNetworkSync();
     this._listenForNewEpoch();
 
-    // FIXME: don't create global singleton; multiple instances of `core` should not all write to global
-    // @ts-expect-error typeof globalThis is not defined. We're going to get rid of the global soon.
-    globalThis.litNodeClient = this;
     this.ready = true;
 
     log(`🔥 lit is ready. "litNodeClient" variable is ready to use globally.`);

packages/crypto/README.md

@@ -7,12 +7,3 @@ The crypto.ts file in the Lit SDK handles cryptographic operations, including th
 ```
 yarn add @lit-protocol/crypto
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/crypto-vanilla/crypto.js"></script>
-<script>
-  console.log(LitJsSdk_crypto);
-</script>
-```

packages/encryption/README.md

@@ -7,12 +7,3 @@ This submodule provides encryption and decryption of contents (string, file, etc
 ```
 yarn add @lit-protocol/encryption
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/encryption-vanilla/encryption.js"></script>
-<script>
-  console.log(LitJsSdk_encryption);
-</script>
-```

packages/lit-node-client-nodejs/src/index.ts

@@ -1,19 +1,5 @@
 import 'cross-fetch/dist/node-polyfill.js';
 
-import * as _LitNodeClientNodeJs from './lib/lit-node-client-nodejs';
-// ==================== Environment ====================
-
-declare global {
-  // This `declare global` hackery _must_ use var to work.
-  // eslint-disable-next-line no-var, @typescript-eslint/no-explicit-any
-  var LitNodeClientNodeJs: any;
-}
-
-const LitNodeClientNodeJs = _LitNodeClientNodeJs.LitNodeClientNodeJs;
-if (!globalThis.LitNodeClientNodeJs) {
-  globalThis.LitNodeClientNodeJs = LitNodeClientNodeJs;
-}
-
 // ==================== Exports ====================
 export * from './lib/lit-node-client-nodejs';
 

packages/lit-node-client/README.md

@@ -7,12 +7,3 @@ This module is the main module of this monorepo. It sets a default authenticatio
 ```
 yarn add @lit-protocol/lit-node-client
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/lit-node-client-vanilla/lit-node-client.js"></script>
-<script>
-  const authSig = LitJsSdk_litNodeClient.checkAndSignAuthMessage({chain: 'ethereum'});
-</script>
-```

packages/lit-node-client/src/index.ts

@@ -1,18 +1,4 @@
-import * as _LitNodeClient from './lib/lit-node-client';
-
-declare global {
-  // This `var` is necessary for global hackery
-  // eslint-disable-next-line no-var, @typescript-eslint/no-explicit-any
-  var LitNodeClient: any;
-}
-
-const LitNodeClient = _LitNodeClient.LitNodeClient;
-if (!globalThis.LitNodeClient) {
-  globalThis.LitNodeClient = LitNodeClient;
-}
-
 // ==================== Exports ====================
-
 export * from './lib/lit-node-client';
 
 export {

packages/misc-browser/README.md

@@ -7,12 +7,3 @@ This submodule includes functions for interaction with local storage (get, set,
 ```
 yarn add @lit-protocol/misc-browser
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/misc-browser-vanilla/misc-browser.js"></script>
-<script>
-  console.log(LitJsSdk_miscBrowser);
-</script>
-```

packages/misc/README.md

@@ -7,12 +7,3 @@ This submodule contains various utility functions for error handling, logging, t
 ```
 yarn add @lit-protocol/misc
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/misc-vanilla/misc.js"></script>
-<script>
-  console.log(LitJsSdk_misc);
-</script>
-```

packages/misc/src/lib/misc.ts

@@ -1,3 +1,4 @@
+import { LitNodeClientConfig } from '@lit-protocol/types';
 import { Contract } from '@ethersproject/contracts';
 import { JsonRpcProvider } from '@ethersproject/providers';
 import Ajv, { JSONSchemaType } from 'ajv';
@@ -31,6 +32,13 @@ import {
 const logBuffer: any[][] = [];
 const ajv = new Ajv();
 
+// Module scoped variable to store the LitNodeClientConfig passed to LitCore
+let litConfig: LitNodeClientConfig | undefined;
+
+export const setMiscLitConfig = (config: LitNodeClientConfig | undefined) => {
+  litConfig = config;
+};
+
 /**
  *
  * Print error message based on Error interface
@@ -95,7 +103,6 @@ export const findMostCommonResponse = (responses: object[]): object => {
 };
 
 declare global {
-  var litConfig: any;
   var wasmExport: any;
   var wasmECDSA: any;
   var logger: any;
@@ -148,13 +155,13 @@ export const log = (...args: any): void => {
   }
 
   // check if config is loaded yet
-  if (!globalThis?.litConfig) {
+  if (!litConfig) {
     // config isn't loaded yet, push into buffer
     logBuffer.push(args);
     return;
   }
 
-  if (globalThis?.litConfig?.debug !== true) {
+  if (litConfig?.debug !== true) {
     return;
   }
   // config is loaded, and debug is true
@@ -176,13 +183,13 @@ export const logWithRequestId = (id: string, ...args: any) => {
   }
 
   // check if config is loaded yet
-  if (!globalThis?.litConfig) {
+  if (!litConfig) {
     // config isn't loaded yet, push into buffer
     logBuffer.push(args);
     return;
   }
 
-  if (globalThis?.litConfig?.debug !== true) {
+  if (litConfig?.debug !== true) {
     return;
   }
   // config is loaded, and debug is true
@@ -206,13 +213,13 @@ export const logErrorWithRequestId = (id: string, ...args: any) => {
   }
 
   // check if config is loaded yet
-  if (!globalThis?.litConfig) {
+  if (!litConfig) {
     // config isn't loaded yet, push into buffer
     logBuffer.push(args);
     return;
   }
 
-  if (globalThis?.litConfig?.debug !== true) {
+  if (litConfig?.debug !== true) {
     return;
   }
   // config is loaded, and debug is true
@@ -236,13 +243,13 @@ export const logError = (...args: any) => {
   }
 
   // check if config is loaded yet
-  if (!globalThis?.litConfig) {
+  if (!litConfig) {
     // config isn't loaded yet, push into buffer
     logBuffer.push(args);
     return;
   }
 
-  if (globalThis?.litConfig?.debug !== true) {
+  if (litConfig?.debug !== true) {
     return;
   }
   // config is loaded, and debug is true

packages/nacl/README.md

@@ -7,12 +7,3 @@ re-export of https://www.npmjs.com/package/nacl
 ```
 yarn add @lit-protocol/nacl
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/nacl-vanilla/nacl.js"></script>
-<script>
-  console.log(LitJsSdk_nacl);
-</script>
-```

packages/pkp-base/README.md

@@ -20,12 +20,3 @@ This submodule defines a PKPBase class, providing shared wallet functionality fo
 ```
 yarn add @lit-protocol/pkp-base
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/pkp-base-vanilla/pkp-base.js"></script>
-<script>
-  console.log(LitJsSdk_pkpBase);
-</script>
-```

packages/uint8arrays/README.md

@@ -12,12 +12,3 @@ Here are the two main functions:
 ```
 yarn add @lit-protocol/uint8array
 ```
-
-### Vanilla JS (UMD)
-
-```js
-<script src="https://cdn.jsdelivr.net/npm/@lit-protocol/uint8array-vanilla/uint8array.js"></script>
-<script>
-  console.log(LitJsSdk_uint8array);
-</script>
-```