Skip to content

Conversation

@Ansonhkg
Copy link
Collaborator

Description

unused case 218 for bls encrypt

@Ansonhkg Ansonhkg requested a review from joshLong145 as a code owner October 10, 2024 18:47
);
}
return Buffer.from(
await blsEncrypt('Bls12381G2', publicKey, message, identity)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter message in the blsEncrypt function call should be replaced with data to correctly use the function parameter defined in the method signature. This ensures consistency with the input parameters and prevents potential errors. Consider updating the line to:

await blsEncrypt('Bls12381G2', publicKey, data, identity)

This change aligns the function call with the method's declared parameters.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

);
}
return Buffer.from(
await blsEncrypt('Bls12381G2', publicKey, message, identity)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blsEncrypt function is called but appears to be undefined in this scope. Please ensure it's properly imported from the appropriate module or defined within this file. If it's a custom implementation, consider adding a comment explaining its origin or providing a reference to its definition.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@Ansonhkg Ansonhkg closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants