Skip to content

Conversation

@Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Nov 26, 2024

Description

The strategy here is to randomly select the network type ('main' net and clonenet), with the ability to override.

Test

NETWORK_TYPE=random NETWORK=datil-test yarn test:local --filter=testUseEoaSessionSigsToPkpSign
NETWORK_TYPE=mainnet NETWORK=datil-test yarn test:local --filter=testUseEoaSessionSigsToPkpSign
NETWORK_TYPE=cloneNet NETWORK=datil-test yarn test:local --filter=testUseEoaSessionSigsToPkpSign

@Ansonhkg Ansonhkg marked this pull request as ready for review December 9, 2024 17:42
@Ansonhkg Ansonhkg self-assigned this Dec 10, 2024
Copy link
Contributor

@hwrdtm hwrdtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as long as we are developing this keeping in mind that some of this will no longer be relevant for naga, eg. CloneNet contract would not exist for naga.

@Ansonhkg
Copy link
Collaborator Author

#712

@Ansonhkg
Copy link
Collaborator Author

to be reopened if required.

@Ansonhkg Ansonhkg closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants