Skip to content

fix: undefined tokenId #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 23, 2024
Merged

fix: undefined tokenId #738

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d1f591
fix: undefined tokenId
Ansonhkg Dec 13, 2024
10cf10b
Merge branch 'master' into feature/drel-378-tg-osmosis-team-facing-is…
Ansonhkg Dec 13, 2024
5116b9d
Merge branch 'master' into feature/drel-378-tg-osmosis-team-facing-is…
Ansonhkg Dec 23, 2024
4c2ec24
Merge branch 'master' into feature/drel-378-tg-osmosis-team-facing-is…
Ansonhkg Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/contracts-sdk/src/lib/contracts-sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1903,10 +1903,14 @@ https://developer.litprotocol.com/v3/sdk/wallets/auth-methods/#auth-method-scope
for (let i = 0; i < tokenIds.length; i++) {
const tokenId = tokenIds[i];
const pubKey = await this.pkpNftContract.read.getPubkey(tokenId);
const addrs = await derivedAddresses({
const addrs: TokenInfo = await derivedAddresses({
Copy link
Contributor

@FedericoAmura FedericoAmura Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should make the tokenId optional in TokenInfo to keep Typescript consistency. This way we can also remove the any in derivedAddresses return type TokenInfo | any

publicKey: pubKey,
});

if (!addrs.tokenId) {
addrs.tokenId = tokenId;
}

arr.push(addrs);
}

Expand Down
Loading