Feature/lit 4124 js sdk naga fix bls wasm #762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansonhkg
requested review from
DashKash54,
GTC6244,
glitch003 and
mikelodder7
mikelodder7
approved these changes
Jan 13, 2025
Contributor
mikelodder7
left a comment
mikelodder7
left a comment
There was a problem hiding this comment.
LGTM as long as it works in the JS side.
… usage - Also send `nodeSet` to `sign_session_key` endpoint as it is required - Fixed typo on name of wasm method for `ecdsaCombineAndVerify` (was previously unused)
…a-dev-support-with-rust-toolchain add rust-toolchain.toml so we autoinstall some necessary rust stuff
…a-add-naga-dev-support feat: add naga dev support
…ithub.com/LIT-Protocol/js-sdk into feature/lit-4124-js-sdk-naga-fix-bls-wasm
Collaborator
Author
|
Closing this soon in favour of feat/naga-fix-bls-wasm-cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fix BLS