modify random wallet generation BaseProvider.ts

[madschristensen99]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[awisniew207]

During my testing, the only change that should be need to the js-sdk in this PR is changing the LitContracts config:

From:

    const litContracts = new LitContracts({
      randomPrivatekey: true,
      network: this.litNodeClient.config.litNetwork,
    });

To:

    const litContracts = new LitContracts({
      signer: new ethers.Wallet(ethers.Wallet.createRandom().privateKey, new ethers.providers.JsonRpcProvider(LIT_RPC.CHRONICLE_YELLOWSTONE)),
      network: this.litNodeClient.config.litNetwork,
    });

[awisniew207]

lgtm! 👍 This solution will prevent a wallet extension from opening in the browser.

A more thorough fix would be refactoring the randomPrivatekey flag to do this, but I don't think that is a must here.

[Ansonhkg]

Closing this. we can have a follow up PR to just remove the randomPrivateKey flag instead, as user can pass in a random signer themselves.