feat(artillery): add init-wallets script and update package.json for … #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…master wallet management
hwrdtm
reviewed
Jul 28, 2025
| // Check and top up wallets from pool | ||
| await MasterAccountManager.checkAndTopupWalletsFromPool({ | ||
| publicClient, | ||
| masterAccount, |
Contributor
There was a problem hiding this comment.
so, we're using the first available master account from L15 to fund all other master accounts from the file that need topping up?
| } | ||
| } | ||
|
|
||
| export const checkAndTopupWalletsFromPool = async ({ |
Contributor
There was a problem hiding this comment.
do we have a check here that the master account we are using to disperse funds has enough funds to cover all the other master accounts that need to be topped up.
| fs.writeFileSync('master-account-pool.json', JSON.stringify(masterAccountPool, null, 2)); | ||
| }; | ||
|
|
||
| export const generateAndFundWalletsFromPool = async ({ |
Contributor
There was a problem hiding this comment.
similar to above, are we missing a check here that the master account has enough funds to fund the newly generated master account wallets? or were you thinking of doing it optimistically / as much as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
pregen and fund a set number of wallets, then store them into the master private key pool file so that the artillery test could pick an available master key from the pool to run a test to prevent nonce issue.