Skip to content

fix(lint): don't auto format, let it fail. We will deal with auto-for… #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(lint): don't auto format, let it fail. We will deal with auto-for… #872

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
997070f
fix(lint): don't auto format, let it fail. We will deal with auto-for…
Ansonhkg Aug 25, 2025
83e2f3e
fmt
Ansonhkg Aug 25, 2025
b9e8a3c
Update .github/workflows/lint.yml
Ansonhkg Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,5 @@ jobs:
run: |
echo "Running format check..."
# Use prettier directly to avoid NX git issues
npx prettier --check . || {
echo "Format check failed. Running prettier --write to fix issues..."
npx prettier --write .
echo "Checking again after formatting..."
npx prettier --check . || {
echo "Still failing after auto-format. Manual intervention needed."
exit 1
}
echo "Auto-formatting successful. All files are now properly formatted."
echo "Note: Some files were auto-formatted. Consider committing these changes in your next commit."
}
npx prettier --check .
echo "Format check passed!"
Loading