[Bug] fix(webauthn): to include scopes in the API #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hs` higher api function
…in auth-services and networks
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
commented
Sep 5, 2025
| export const tAuthServiceMintRequestSchema = t.Object({ | ||
| authMethodType: t.String(), | ||
| authMethodId: t.String(), | ||
| pubkey: t.Optional(t.String({ default: '0x' })), |
Collaborator
Author
There was a problem hiding this comment.
This caused Unable to decode credential public key CBOR
Ansonhkg
commented
Sep 5, 2025
packages/auth-services/src/queue-manager/src/handlers/pkpMint/pkpMint.handler.ts
Outdated
Show resolved
Hide resolved
Ansonhkg
changed the title
Ansonhkg
changed the title
MaximusHaximus
requested changes
Sep 9, 2025
Contributor
MaximusHaximus
left a comment
MaximusHaximus
left a comment
There was a problem hiding this comment.
Added a few issues in-line
packages/auth-services/src/queue-manager/src/handlers/pkpMint/pkpMint.handler.ts
Outdated
Show resolved
Hide resolved
packages/auth-services/src/auth-server/src/schemas/AuthServiceMintRequestSchema.ts
Outdated
Show resolved
Hide resolved
...rc/networks/vNaga/shared/managers/LitChainClient/apis/highLevelApis/mintPKP/MintPKPSchema.ts
Outdated
Show resolved
Hide resolved
packages/auth/src/lib/authenticators/native/WebAuthnAuthenticator.ts
Outdated
Show resolved
Hide resolved
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
…lers to use unified schema
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Collaborator
Author
|
consolidated 4 different PKP mint schemas and scopes. All networks APIs now import from schemas package instead of internally |
This was referenced Sep 15, 2025
MaximusHaximus
requested changes
Sep 16, 2025
Contributor
MaximusHaximus
left a comment
MaximusHaximus
left a comment
There was a problem hiding this comment.
Nice job getting rid of the duplication -- just a few things added in-line
| // Accept string, number, or enum for backwards compatibility | ||
| authMethodType: z | ||
| .union([ | ||
| AuthMethodSchema.shape.authMethodType, // z.nativeEnum(AUTH_METHOD_TYPE) |
Contributor
There was a problem hiding this comment.
We haven't used native enums anywhere in the SDK since aug of '24
I tried running the schemas file using tsx directly, and got an error `ReferenceError: Cannot access 'LitAbilitySchema' before initialization which is related to weird corner-cases with native enums, highlighting why we stopped using them :)
packages/auth-services/src/queue-manager/src/handlers/pkpMint/pkpMint.handler.ts
Outdated
Show resolved
Hide resolved
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Collaborator
Author
|
so the logic flow is:
|
Ansonhkg
commented
Sep 16, 2025
Signed-off-by: Anson <[email protected]>
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Signed-off-by: Anson <[email protected]>
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Closed
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
MaximusHaximus
requested changes
Sep 17, 2025
Contributor
MaximusHaximus
left a comment
MaximusHaximus
left a comment
There was a problem hiding this comment.
👍 Looking pretty close -- just one question about the possible input for the custom schema which we are trying to coerce to a number, even though it appears it could be > 2^53 -- and z.nativeEnum usage that might've been missed in my last review.
| pubkey: HexPrefixedSchema.default('0x'), | ||
| scopes: z.array(ScopeSchemaRaw).optional().default([]), | ||
| }) | ||
| .refine( |
Contributor
There was a problem hiding this comment.
💖 nice, this makes sense
Ansonhkg
deleted the
feature/jss-86-bugnaga-fix-webauthn-cbor-issue-due-to-missing-pub-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
0xcausing "misleading" (technically correct) unable to decode credential public key CBOR.