[Bug] fix some methods are returning :any #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
This was referenced Sep 15, 2025
glitch003
approved these changes
Sep 16, 2025
Collaborator
glitch003
left a comment
glitch003
left a comment
There was a problem hiding this comment.
looks good - just add types, pretty simple
…bug-some-methods-are-returning-any-2 Signed-off-by: Anson <[email protected]>
Ansonhkg
had a problem deploying
to
Health Check
GitHub Actions
Failure
Ansonhkg
deleted the
feature/jss-82-naga-bug-some-methods-are-returning-any-2
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
The ugly import("dist/...") paths happen because the return/param types are not imported/re-exported from the public entry points. When TS generates declarations without a named import in scope, it inlines a path to the implementation file in the built output.
What this breaks
The would affect user experience because when they call these function it will just return :any type. This wasn't affecting local development because I was using locally linked packages and it was able to resolve the types.
Affected methods
Solution
Map each offending signature to the external types it needs, expose them via package entry point and import them inside createLitClient