chore: add GitHub Actions workflow for releasing Docker images #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a GitHub Actions workflow for building and publishing Docker images for Naga applications to GitHub Container Registry (GHCR). The workflow provides control over when images are published through a manual trigger with boolean input.
- Introduces manual workflow dispatch with configurable release flag
- Sets up Docker build environment with Node.js and PNPM dependencies
- Implements matrix strategy to build multiple applications (lit-auth-server, lit-login-server)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| fi | ||
| echo "$tags_to_push" | while IFS= read -r tag; do | ||
| [ -z "$tag" ] && continue | ||
| docker tag "$IMAGE_NAME" "$tag" |
There was a problem hiding this comment.
The docker tag command uses '$IMAGE_NAME' as the source image, but this assumes the image was built with that exact name. The Nx docker-build target might create an image with a different name. You should either use the actual built image name or ensure the Nx target creates an image with the expected name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add workflow to publish docker images for Naga