ci(release): ensure Changesets uses naga tip; conditionally clean rel… #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the CI release workflow by ensuring proper handling of the workflow run commit and conditionally cleaning release branches. The changes focus on more reliable branch management and workflow execution.
- Extracts branch name into a variable for consistency across operations
- Replaces unconditional branch deletion with conditional logic that checks for branch existence
- Removes the
commitMode: githubconfiguration parameter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| BRANCH="${{ github.event.workflow_run.head_branch }}" | ||
| git fetch --no-tags --prune origin | ||
| git push origin :changeset-release/${{ github.event.workflow_run.head_branch }} || true | ||
| if git ls-remote --heads origin "changeset-release/$BRANCH" | grep -q .; then |
There was a problem hiding this comment.
The grep -q . pattern is unclear. Consider using a more explicit check like grep -q "changeset-release/$BRANCH" or | wc -l to make the intent clearer.
Suggested change
| if git ls-remote --heads origin "changeset-release/$BRANCH" | grep -q .; then | |
| if git ls-remote --heads origin "changeset-release/$BRANCH" | grep -q "changeset-release/$BRANCH"; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT