fix(auth,auth-helpers,lit-client,networks): set viem as a peer depend… #957
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the viem dependency management by moving viem from direct dependencies to peerDependencies across four key packages. This allows consuming applications to manage their own viem version while ensuring compatibility.
- Moved viem from dependencies to peerDependencies in four packages
- Changed viem version constraint from exact (2.29.4) to compatible (^2.29.4)
- Maintained existing peerDependencies structure where applicable
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/networks/package.json | Moved viem from dependencies to new peerDependencies section |
| packages/lit-client/package.json | Moved viem from dependencies to new peerDependencies section |
| packages/auth/package.json | Moved viem from dependencies to existing peerDependencies section |
| packages/auth-helpers/package.json | Moved viem from dependencies to new peerDependencies section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/networks/package.json
Outdated
| "@noble/hashes": "^1.8.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "viem": "^2.29.4" |
There was a problem hiding this comment.
The version constraint changed from exact version '2.29.4' to compatible version '^2.29.4'. This allows patch and minor version updates which could introduce breaking changes in viem's API. Consider using a more restrictive constraint like '~2.29.4' to only allow patch updates, or document the supported viem version range.
| "viem": "^2.29.4" | |
| "viem": "~2.29.4" |
packages/lit-client/package.json
Outdated
| "zod": "3.24.3" | ||
| }, | ||
| "peerDependencies": { | ||
| "viem": "^2.29.4" |
There was a problem hiding this comment.
The version constraint changed from exact version '2.29.4' to compatible version '^2.29.4'. This allows patch and minor version updates which could introduce breaking changes in viem's API. Consider using a more restrictive constraint like '~2.29.4' to only allow patch updates, or document the supported viem version range.
| "viem": "^2.29.4" | |
| "viem": "~2.29.4" |
packages/auth/package.json
Outdated
| "peerDependencies": { | ||
| "tslib": "^2.3.0" | ||
| "tslib": "^2.3.0", | ||
| "viem": "^2.29.4" |
There was a problem hiding this comment.
The version constraint changed from exact version '2.29.4' to compatible version '^2.29.4'. This allows patch and minor version updates which could introduce breaking changes in viem's API. Consider using a more restrictive constraint like '~2.29.4' to only allow patch updates, or document the supported viem version range.
| "viem": "^2.29.4" | |
| "viem": "~2.29.4" |
packages/auth-helpers/package.json
Outdated
| "@ethersproject/transactions": "5.7.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "viem": "^2.29.4" |
There was a problem hiding this comment.
The version constraint changed from exact version '2.29.4' to compatible version '^2.29.4'. This allows patch and minor version updates which could introduce breaking changes in viem's API. Consider using a more restrictive constraint like '~2.29.4' to only allow patch updates, or document the supported viem version range.
| "viem": "^2.29.4" | |
| "viem": "~2.29.4" |
…rt_memoirist = require("memoirist")` error
…ckages which should include the `sendCallsSync` function what wagmi is looking for. Snapshot published: 🦋 New tag: @lit-protocol/[email protected] 🦋 New tag: @lit-protocol/[email protected] 🦋 New tag: @lit-protocol/[email protected] 🦋 New tag: @lit-protocol/[email protected] 🦋 New tag: @lit-protocol/[email protected] 🦋 New tag: @lit-protocol/[email protected] 🦋 New tag: @lit-protocol/[email protected] 🦋 New tag: @lit-protocol/[email protected]
|
New snapshots published: 🦋 New tag: @lit-protocol/auth@0.0.0-20251020130647
🦋 New tag: @lit-protocol/auth-helpers@0.0.0-20251020130647
🦋 New tag: @lit-protocol/auth-services@0.0.0-20251020130647
🦋 New tag: @lit-protocol/constants@0.0.0-20251020130647
🦋 New tag: @lit-protocol/contracts@0.0.0-20251020130647
🦋 New tag: @lit-protocol/e2e@0.0.0-20251020130647
🦋 New tag: @lit-protocol/lit-client@0.0.0-20251020130647
🦋 New tag: @lit-protocol/networks@0.0.0-20251020130647 |
This has been tested by customer and is now working: |
Ansonhkg
requested review from
FedericoAmura,
MaximusHaximus,
glitch003 and
spacesailor24
WHAT
We have a
viemversion conflicts because theviemversion we bundled in the SDK is not the same as the onewagmiis using internally. To fix this, we need to moveviemfrom dependencies intopeerDependenciesfor@lit-protocol/auth,auth-helpers,lit-client, andnetworkspackages, so consumers will supply their own compatibleviemversions.FIX
:anyatm.TEST
Snapshots are published for the following packages:
Relevant PRs and Issues
nagaDevin v8 #958