Feature/node 4876 - using both chains in some tests ( adapt end user to support pkps in both chains ) #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PKP assertions across chain This is incomplete.
…datil-naga-assertions
…PKP assertions across chain This is incomplete.
…-Protocol/lit-peer into hwrdtm/datil-naga-assertions
…l' into feature/node-4876-adapt-the-end-user-to-support-pkps-in-both-chains
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adapts the end-user concept to support PKPs (Programmable Key Pairs) in both Naga and Datil chains. The main changes include:
- Refactored key_set_id handling from
Option<String>to&strfor more consistent parameter passing - Added Datil contract integration and authentication support
- Introduced keyset utility functions for managing default keysets
- Updated string formatting throughout the codebase to use inline format syntax
- Added support for Datil PKP operations in tests
Reviewed changes
Copilot reviewed 145 out of 147 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/lit-node/lit-node/src/utils/keysets.rs | New utility module for keyset management including default keyset retrieval |
| rust/lit-node/lit-node/src/utils/datil_contract.rs | New module for Datil contract interactions |
| rust/lit-node/lit-node/src/pkp/auth/datil.rs | New authentication module for Datil PKPs |
| rust/lit-node/lit-node/src/tss/common/curve_state.rs | Refactored to use non-optional key_set_id |
| rust/lit-node/lit-node/src/endpoints/web_client.rs | Updated to use default keyset utilities |
| rust/lit-node/lit-node/src/pkp/utils.rs | Added Datil-specific pubkey routing logic |
| rust/lit-node/lit-node-testnet/src/testnet/datil/contracts.rs | New Datil contracts wrapper |
| Multiple test files | Updated to pass key_set_id parameters and use new APIs |
| Multiple files | String formatting updates (cosmetic changes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GTC6244
changed the title
glitch003
approved these changes
Jan 6, 2026
Base automatically changed from
feature/node-4874-support-multiple-chains-at-anvil-level
to
keysets
January 6, 2026 18:25
…upport-pkps-in-both-chains
…pport-pkps-in-both-chains
* update to determine key set for recovery Signed-off-by: Michael Lodder <[email protected]> * add test when no key set is on chain Signed-off-by: Michael Lodder <[email protected]> * update test Signed-off-by: Michael Lodder <[email protected]> --------- Signed-off-by: Michael Lodder <[email protected]> Co-authored-by: Brendon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Initially meant to just adapt the
end-userconcept, there was no way to test without actually making changes directly in the nodes and add in the endpoints.