Skip to content

Ensure we're checking the correct config data when using the clear of… #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GTC6244 wants to merge 5 commits into
base: keysets
Choose a base branch
from
Open

Ensure we're checking the correct config data when using the clear of… #72

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83b47a5
Ensure we're checking the correct config data when using the clear of…
GTC6244 Jan 13, 2026
189e3ce
cargo fmt
GTC6244 Jan 14, 2026
d329fb4
cargo /clippy.
GTC6244 Jan 14, 2026
689a7c2
Merge branch 'keysets' into feature/node-4936-turn-off-presigs-comple…
GTC6244 Jan 14, 2026
12983d4
Merge branch 'keysets' into feature/node-4936-turn-off-presigs-comple…
GTC6244 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions rust/lit-node/lit-node/src/tasks/presign_manager/listener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ impl PresignManager {
all_presign_list.push(presign_list);
}

self.set_chain_defaults();
let _ = self.set_chain_defaults(false).await;

let cfg = config.load_full();
let timeout = cfg
Expand Down Expand Up @@ -144,6 +144,9 @@ impl PresignManager {
self.broadcast_to_non_participants(request_key_hash, peers).await;
}
PresignMessage::Clear => {
// avoids re-starting the presign generation process if the chain defaults change.
// this is a blocking function on a hot path, but is intentional.
let _ = self.set_chain_defaults(true).await;
for curve_type in [CurveType::K256, CurveType::P256, CurveType::P384] {
if let Some(presign_list) = get_presign_list_by_curve_type(&mut all_presign_list, curve_type) {
self.presign_message_clear(curve_type, presign_list).await;
Expand Down Expand Up @@ -192,13 +195,26 @@ impl PresignManager {
}
}
_ = heartbeat.tick() => {
self.set_chain_defaults();
let _ = self.set_chain_defaults(false).await;
}
}
}
}

fn set_chain_defaults(&mut self) {
async fn set_chain_defaults(&mut self, invalidate_chain_cache: bool) -> Result<()> {
if invalidate_chain_cache {
self.tss_state
.chain_data_config_manager
.set_all_config_from_chain()
.await
.map_err(|e| {
unexpected_err(
e,
Some("Error setting chain defaults from presign manager.".to_string()),
)
})?;
}

DataVersionReader::reader_unchecked(
&self.tss_state.chain_data_config_manager.generic_config,
|generic_chain_config| {
Expand All @@ -208,6 +224,7 @@ impl PresignManager {
self.max_presign_concurrency = generic_chain_config.max_presign_concurrency;
},
);
Ok(())
}

#[instrument(level = "debug", skip_all, fields(txn_prefix = req.txn_prefix))]
Expand Down