RPC Resolver: Healthcheck always on #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Garandor
requested review from
DashKash54,
GTC6244,
glitch003 and
kapoorabhishek24
Garandor
changed the title
Garandor
changed the title
Garandor
changed the title
Garandor
changed the title
|
PASS [ 44.721s] (3/3) lit_node::test toxiproxy::perf_tests::load_with_no_latency |
GTC6244
previously approved these changes
Jan 21, 2026
Contributor
GTC6244
left a comment
GTC6244
left a comment
There was a problem hiding this comment.
lgtm. Have a question around why you re-added the deprecated value, but will approve anyway so you can merge without needing a re-review! ;-)
Garandor
force-pushed
the
always_poll_rpcs
branch
from
d212de3 to
4dcf20f
Compare
Garandor
force-pushed
the
always_poll_rpcs
branch
from
4dcf20f to
e86173e
Compare
GTC6244
approved these changes
Jan 22, 2026
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR marks the
rpc_healthcheck_enabledflag as deprecated and removes its functionality from the RPC health check polling logic.Cleanup of this flag from the config will happen in a later PR
Why
The RPC health check functionality should always be enabled, making the toggle unnecessary. Removing the conditional check simplifies the code.
Risks