feat(dca-backend): bump uniswap ability to version 8.0.0, add job-specific versioning#31
Open
awisniew207 wants to merge 5 commits intomainfrom
Open
feat(dca-backend): bump uniswap ability to version 8.0.0, add job-specific versioning#31awisniew207 wants to merge 5 commits intomainfrom
awisniew207 wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MaximusHaximus
changed the title
MaximusHaximus
force-pushed
the
feat/update-uniswap-ability
branch
from
b21aba4 to
b3279d9
Compare
MaximusHaximus
force-pushed
the
feat/update-uniswap-ability
branch
from
f559ea2 to
680324d
Compare
MaximusHaximus
force-pushed
the
feat/update-uniswap-ability
branch
2 times, most recently
from
926fdcd to
7c94af3
Compare
MaximusHaximus
force-pushed
the
feat/update-uniswap-ability
branch
from
7c94af3 to
680324d
Compare
… functionality for fresh clones of the app repo - Also Quoted invalid values in .env.example file since spaces are only allowed in quoted values.
MaximusHaximus
force-pushed
the
feat/update-uniswap-ability
branch
from
2fc2180 to
812e4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for the new v8.x Uniswap ability which has built-in approval handling.
Retains existing support for v5.x of the Uniswap, along with the explicit independent approval ability for existing schedules.
Better Approval Waiting
Inside
handle-operation-execution.ts, since otherwise the RPC wouldn't update fast enough and our allowance check would fail.Renames
Tool->AbilityRemovals
Removed the erc20 ability completely
Removed the 5x token approval. It seemed pretty overkill. If I want to swap $10, I need to have at least $50?
Testing
Tested with and without sponsorship, both until guaranteed success