Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
A release bump to version 3.3.0 that adds a safe default for num_attempts and updates tests and examples accordingly
- Introduce
_DEFAULT_NUM_ATTEMPTSand patch logic to ensurenum_attemptsfalls back to 3 - Bump
__version__, docs, and bumpversion config to 3.3.0 - Update tests and example notebooks to reflect the new default
num_attempts
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/openai_client_lm_studio_test.py | Expand test cases to cover multiple presets |
| src/llamator/utils/attack_params.py | Add _DEFAULT_NUM_ATTEMPTS and patch num_attempts |
| src/llamator/version.py | Bump package version to 3.3.0 |
| docs/howtos.md & README.md | Update installation instructions to 3.3.0 |
| .bumpversion.cfg | Update bumpversion current_version to 3.3.0 |
| examples/*.ipynb | Refresh notebook execution metadata and outputs |
Comments suppressed due to low confidence (2)
examples/llamator-whatsapp.ipynb:43
- [nitpick] These notebooks include updated outputs and execution metadata, causing very large diffs. Consider clearing cell outputs and execution counts before committing to reduce noise.
"execution_count": 1
tests/openai_client_lm_studio_test.py:36
- The test for
aim_jailbreakonly assertsnum_attempts, but the implementation likely also returns default parameters likecustom_datasetorlanguage. Include all expected default keys in the assertion to keep the test accurate.
("aim_jailbreak", {"num_attempts": 3}),
nizamovtimur
approved these changes
Jul 15, 2025
nizamovtimur
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update version to 3.3.0