Conversation
We do this so we naturally get an implementation for lists of things that do HashInto. It's hard to arrange otherwise.
To allow for using faster multi-exp algorithms now used in backend.
Nobody actually needs this!
Closed
RCasatta
reviewed
Jan 12, 2022
| /// Returns a reference to the public key. | ||
| pub fn public_key(&self) -> &XOnly { | ||
| &self.pk | ||
| pub fn public_key(&self) -> XOnly { |
There was a problem hiding this comment.
Any rationale on why you go this way (by value instead ref?)
Owner
Author
There was a problem hiding this comment.
XOnly is Copy so I think it's conventional to not return references to Copy things. On top of that There's no reason to leak the implementation that keyPair stores an XOnly (it could store a Point<EvenY> instead).
(that comment needs to change though).
And add a way to clear them manually to try and discourage serializing nonces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort of compatible with: BlockstreamResearch/secp256k1-zkp#131
relevant new code is in
musig.rsthe rest is just yak shaving.