Skip to content

fix: broken workflow diagram and scroll jump on anchor modal#199

Merged
rdmueller merged 1 commit intoLLM-Coding:mainfrom
raifdmueller:fix/workflow-image-and-scroll
Mar 15, 2026
Merged

fix: broken workflow diagram and scroll jump on anchor modal#199
rdmueller merged 1 commit intoLLM-Coding:mainfrom
raifdmueller:fix/workflow-image-and-scroll

Conversation

@raifdmueller
Copy link
Contributor

@raifdmueller raifdmueller commented Mar 15, 2026

Summary

Follow-up to #198 — the second commit was pushed after merge and missed deployment.

  • Broken image: Fix workflow-diagram.png path to docs/workflow-diagram.png (relative to SPA root)
  • Scroll jump: Preserve and restore scroll position when opening/closing anchor modal on doc pages

Test plan

  • Workflow diagram displays correctly on Spec-Driven Workflow page
  • Click anchor link on doc page → no scroll jump, modal opens as overlay
  • Close modal → page returns to previous scroll position

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Verbesserte Scroll-Position-Verwaltung beim Schließen von Modalen, um die vorherige Scroll-Position wiederherzustellen.
  • Documentation

    • Aktualisierte Bildverweise in der Dokumentation.

- Fix image path: use docs/workflow-diagram.png (relative to SPA root)
- Preserve scroll position when opening anchor modal from doc pages
- Restore scroll position when closing modal back to previous page

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Das PR aktualisiert Dokumentationsbildpfade von workflow-diagram.png zu docs/workflow-diagram.png und implementiert Scroll-Positions-Tracking beim Schließen von Anker-Modalen, indem eine neue Funktion getScrollBeforeModal() eingeführt und in die Modal- und Router-Logik integriert wird.

Changes

Cohort / File(s) Zusammenfassung
Dokumentations-Bildpfade
docs/spec-driven-workflow.adoc, docs/spec-driven-workflow.de.adoc
Bildpfade für Workflow-Diagramm von image::workflow-diagram.png zu image::docs/workflow-diagram.png aktualisiert.
Scroll-Positions-Tracking
website/src/components/anchor-modal.js, website/src/utils/router.js
Scroll-Positions-Speicherung vor dem Öffnen von Anker-Modalen hinzugefügt; neue Exportfunktion getScrollBeforeModal() eingeführt; Modal-Schließ-Logik nutzt gespeicherte Position zur Scroll-Wiederherstellung.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Der Titel beschreibt genau die beiden Hauptänderungen: Behebung des defekten Workflow-Diagramms und Behebung des Scroll-Springs bei der Ankermodalität.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rdmueller rdmueller merged commit dd7339b into LLM-Coding:main Mar 15, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants