Skip to content

feat: show comments in modal and remove badge links#320

Merged
rdmueller merged 2 commits intoLLM-Coding:mainfrom
raifdmueller:feat/feedback-comments
Mar 18, 2026
Merged

feat: show comments in modal and remove badge links#320
rdmueller merged 2 commits intoLLM-Coding:mainfrom
raifdmueller:feat/feedback-comments

Conversation

@raifdmueller
Copy link
Contributor

@raifdmueller raifdmueller commented Mar 18, 2026

Summary

  • Comments in modal: Show up to 10 recent comments (avatar, author, text) from GitHub Discussions directly in the anchor modal, above the Vote/Discuss buttons
  • Card badges: Upvote and comment counts are now plain text badges without links — interaction happens via the modal buttons
  • feedback.json: Now includes recentComments array with author, avatar, body, date

Test plan

  • Open Socratic Method anchor → comment from rdmueller visible in modal
  • Upvote/comment badges on cards are not clickable
  • All 87 unit tests pass

🤖 Generated with Claude Code

Summary by CodeRabbit

Versionshinweise

  • Neue Funktionen

    • Aktuelle Kommentare werden nun in der Feedback-Ansicht angezeigt, inklusive Autor, Avatar und Kommentartext.
  • Fehlerbehebungen

    • Abstimmungs- und Kommentarabzeichen sind nicht länger anklickbar und verhalten sich rein informativ.

raifdmueller and others added 2 commits March 18, 2026 13:05
Upvote count and comment count on cards are now plain badges
without links. Voting and discussing happens via the buttons
in the anchor modal.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fetch up to 10 recent comments per discussion (author, avatar, body, date)
- Render comments above the Vote/Discuss buttons in the modal
- Update feedback.json with comment content

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rdmueller rdmueller merged commit fe4ffdd into LLM-Coding:main Mar 18, 2026
5 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 54358d0d-53d1-45f9-8fc5-0d315f556720

📥 Commits

Reviewing files that changed from the base of the PR and between 8bf9002 and 45eb239.

📒 Files selected for processing (5)
  • scripts/fetch-discussion-votes.js
  • website/public/data/feedback.json
  • website/src/components/anchor-modal.js
  • website/src/components/card-grid.js
  • website/src/styles/main.css

Walkthrough

Die Pull Request erweitert die GraphQL-Abfrage zur Erfassung von Kommentardetails mit Autor, Avatar und Erstellungsdatum. Die abgerufenen Daten werden in einem recentComments-Array strukturiert und an mehreren UI-Komponenten zum Anzeigen und Stylen von Kommentaren verarbeitet. Upvotes- und Kommentare-Badges werden von Links in nicht anklickbare Spans konvertiert.

Changes

Cohort / Datei(en) Zusammenfassung
Datenabfrage und -speicher
scripts/fetch-discussion-votes.js, website/public/data/feedback.json
GraphQL-Abfrage wird um Kommentardetails mit totalCount und nodes-Array erweitert. Daten-Strukturierung fügt recentComments-Array zu Feedback-Einträgen hinzu und mappt Autor, Avatar, Body und Erstellungsdatum.
UI-Rendering
website/src/components/anchor-modal.js, website/src/components/card-grid.js
Modal-Komponente rendert neue Kommentarabschnitte mit Avatar und Autor. Card-Komponente konvertiert Upvotes- und Kommentare-Badges von anklickbaren Links zu nicht-anklickbaren Spans.
Styling
website/src/styles/main.css
Neue Tailwind-Utility-Klassen für Feedback-Kommentare-UI hinzugefügt: feedback-comments, feedback-comment, feedback-avatar, feedback-comment-body, feedback-author und feedback-text.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • PR #196: Modifiziert dieselbe renderAnchorCard-Komponente in website/src/components/card-grid.js, um Meta-Badges für Anchor-Cards zu ändern (diese PR konvertiert Upvotes/Kommentare-Badges von Links zu Spans, PR #196 entfernt stattdessen das Tags-Badge).
  • PR #318: Modifiziert dieselben Dateien in der Feedback-Pipeline (scripts/fetch-discussion-votes.js, website/public/data/feedback.json, website/src/components/anchor-modal.js, website/src/components/card-grid.js und Styles), um diskussionsgestützte Feedback-Daten und aktuelle Kommentare hinzuzufügen.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants