Skip to content

Conversation

@K-dash
Copy link
Contributor

@K-dash K-dash commented Oct 11, 2025

Summary

  • Add comprehensive unit tests for llmsql/utils/ modules (regex_extractor, evaluation_utils,
    utils, rich_utils)
  • Add tests for package initialization (__init__.py)
  • Add edge case tests for evaluator and finetune modules

Improve overall code coverage from 51% to 75%

Test Coverage Improvements

  • utils/regex_extractor.py: 21% → 93%
  • utils/evaluation_utils.py: 17% → 100%
  • utils/utils.py: 35% → 100%
  • utils/rich_utils.py: 25% → 100%
  • prompts/prompts.py: 50% → 100%
  • evaluation/evaluator.py: 82% → 94%
  • finetune/finetune.py: 86% → 91%
  • __init__.py: 70% → 90%

Changes

  • Added 89 new test cases across 6 test files
  • Focus on essential and valuable tests (error handling, edge cases, core functionality)

Closes #21

@DzmitryPihulski
Copy link
Collaborator

Thank you very much for your contribution💜, I will check and merge it soon!

Feel free to contribute more issues or/and pr-s⭐

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@DzmitryPihulski DzmitryPihulski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, will be merged soon

@K-dash
Copy link
Contributor Author

K-dash commented Oct 13, 2025

@DzmitryPihulski
Thank you for reviewing my PR!

@DzmitryPihulski DzmitryPihulski self-assigned this Oct 13, 2025
@DzmitryPihulski DzmitryPihulski merged commit 762088f into LLMSQL:main Oct 13, 2025
@K-dash K-dash deleted the add-utils-tests-coverage branch October 13, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add better code coverage

2 participants