Skip to content

Potential fix for code scanning alert no. 73: Server-side request forgery #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
idranme wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 73: Server-side request forgery #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/webui/BE/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,33 +857,40 @@
}

// URL 解码
let url = decodeURIComponent(urlParam)
this.ctx.logger.info('图片代理请求:', url)
const decodedUrl = decodeURIComponent(urlParam)
this.ctx.logger.info('图片代理请求:', decodedUrl)

// 验证 URL 是否是 QQ 图片服务器
let parsedUrl: URL
try {
parsedUrl = new URL(url)
parsedUrl = new URL(decodedUrl)
} catch (e) {
res.status(400).json({ success: false, message: '无效的URL' })
return
}

// 只允许 http/https 协议，防止 SSRF 到其他协议
if (parsedUrl.protocol !== 'http:' && parsedUrl.protocol !== 'https:') {
res.status(400).json({ success: false, message: '不支持的URL协议' })
return
}

const allowedHosts = ['gchat.qpic.cn', 'multimedia.nt.qq.com.cn', 'c2cpicdw.qpic.cn', 'p.qlogo.cn', 'q1.qlogo.cn']
if (!allowedHosts.some(host => parsedUrl.hostname.includes(host))) {
if (!allowedHosts.some(host => parsedUrl.hostname === host)) {
res.status(403).json({ success: false, message: '不允许代理此域名的图片' })
return
}

// 如果 URL 没有 rkey，尝试添加
if (!url.includes('rkey=') && (parsedUrl.hostname.includes('multimedia.nt.qq.com.cn') || parsedUrl.hostname.includes('gchat.qpic.cn'))) {
if (!parsedUrl.searchParams.has('rkey') && (parsedUrl.hostname === 'multimedia.nt.qq.com.cn' || parsedUrl.hostname === 'gchat.qpic.cn')) {
try {
const appid = parsedUrl.searchParams.get('appid')
if (appid && ['1406', '1407'].includes(appid)) {
const rkeyData = await this.ctx.ntFileApi.rkeyManager.getRkey()
const rkey = appid === '1406' ? rkeyData.private_rkey : rkeyData.group_rkey
if (rkey) {
url = url + rkey
// 通过 URL 接口安全地设置 rkey 参数
parsedUrl.searchParams.set('rkey', rkey)
this.ctx.logger.info('已添加 rkey 到图片 URL')
}
}
Expand All @@ -892,13 +899,15 @@
}
}

const response = await fetch(url, {
const finalUrl = parsedUrl.toString()

const response = await fetch(finalUrl, {
headers: {
'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36',
'Accept': 'image/webp,image/apng,image/*,*/*;q=0.8',
'Accept-Language': 'zh-CN,zh;q=0.9,en;q=0.8',
}
})

Check failure

Code scanning / CodeQL

Server-side request forgery Critical

The
URL
Loading
of this request depends on a
user-provided value
Loading
.

if (!response.ok) {
this.ctx.logger.warn('图片代理请求失败:', response.status, response.statusText)
Expand Down
Loading