-
Notifications
You must be signed in to change notification settings - Fork 228
feat: onebot 自定义合并转发外显和嵌套合并转发支持 #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (bug_risk): 嵌套 node 的处理会忽略该 node 的
content中的非 node 元素,可能导致数据丢失。当
hasNestedNodes为 true 时,innerEncoder只接收innerNodes,会忽略content中的非 node 条目。如果协议允许在同一内容中混合 node 和其他 segment 类型,那么这些非 node 部分在嵌套转发中就会丢失。如果需要保留混合内容,请将完整的content传入innerEncoder.generate。否则,请在节点中显式文档化或防护这类混合内容,以避免误用。Original comment in English
question (bug_risk): Nested node handling ignores non-node elements in a node’s
content, which may drop data.When
hasNestedNodesis true,innerEncoderreceives onlyinnerNodesand ignores any non-node entries incontent. If the protocol permits mixing nodes with other segment types, those non-node parts will be lost in nested forwards. If mixed content should be preserved, pass the fullcontentintoinnerEncoder.generate. Otherwise, explicitly document or guard against mixed content in nodes.