Debug fix #5140
Merged
Debug fix #5140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our debugger has been broken for a while. There has been recent progress in Cypari toward fixing it for real, but that still hasn't been achieved. However, there is a workaround that can get some of the functionality back.
There are two features that using
--debuggives you: it gives you an in-browser traceback and debug prompt, and it makes it so that the application automatically restarts if source files are changed. It's actually this second feature that conflicts with Pari's threading, and it's possible to separate the two. This PR adds a new command line argument,--restart, for this second feature (off by default). As a consequence, if you're working on parts of the LMFDB that use pari you can use--debugsuccessfully, but you'll have to restart manually if there are code changes. If you're working on a part of the LMFDB where pari isn't being called you can use--debug --restartto get the original behavior.To test, you can use the fact that http://localhost:37777/NumberField/8.0.97571192547662768845333987328.43
is currently causing server errors.