Skip to content

Conversation

@roed314
Copy link
Member

@roed314 roed314 commented Nov 14, 2024

Fixes #5003.

@JohnCremona
Copy link
Member

It certainly works, but the change is quite subtle. Does it have to be another shade of blue? Would something more eye-catching like flashing text be too much?!

@roed314
Copy link
Member Author

roed314 commented Nov 15, 2024

I don't know what you mean by flashing text; something like this seems unwise to me.

I tried using a grey background (using color.button_background_inactive) rather than the light blue, but I didn't think that was appropriate since the button is still functional. Besides, I prefer having the difference be subtle, since I don't want it to be jarring for users.

@JohnCremona
Copy link
Member

Fair enough -- I wasn't being serious about blinking. Thanks for implementing this!

@roed314
Copy link
Member Author

roed314 commented Nov 15, 2024

Ah, I couldn't tell if you were joking or if there was some different way to interpret the suggestion. 😄

@AndrewVSutherland AndrewVSutherland merged commit 99713dd into LMFDB:main Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate when search results are out of date

3 participants