-
Notifications
You must be signed in to change notification settings - Fork 229
Family pages #6324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Family pages #6324
Conversation
|
This is now up on https://blue.lmfdb.xyz/ModularCurve/Q/ if anyone wants to take a look. |
|
The test failure now is probably due to a data change in local fields and not your fault. @jwj61 are you able to take a look? |
|
Actually, the problem is that including the Galois group is now broken for padic fields. I noticed this earlier today and was going to look at it tomorrow anyway. |
|
Yes, it is a data problem (and my fault). Rewrite in progress. |
|
Should be fixed now. On a tangentially related note, we currently have columns gal and galT which are exactly the same. I suggest deleting galT after removing it from the code (it is easy to search for the few instances of galT). Objections? |
|
I certainly agree on dropping the column eventually, but I would wait until everything gets updated to not use the old column (the main thing that breaks color branches is dropping columns). |
|
Apologies for the delay in reviewing this, I noticed a few issues. Small things:
Big things:
We should decide whether we want to have separate families for X_1(M,MN) (which would only be relevant for M=2) and X_{arith,1}(M,MN), and similarly for X_{+/-1}(M,MN) (which would only be relevant for M =2,3) and X_{arith,+/-1}(M,MN). Let's discuss this on the EDIT: When kicking off that discussion I realized that I think we should not have separate families for X_1(M,MN) and X_{+/-1}(M,MN), the curves that are present (under our surjective determinant constraint) will show up in the arith families anyway, but I do think we should label them without the "arith" when it is not needed (as we do with X(2) in the X_arith(N) family). |
|
It looks like you give the correct moduli description for X_{arith,1}(M,MN) and X_{arith,+/-1}(M,MN) in your paper arXiv:2501.10883, you should just make the pages in this PR match your paper :) |
|
We addressed the minor issues above. We will wait for the Zulip discussion to mature before we make edits on the major issue. |
update parse_family to use new Xarith1 and Xarithpm1 names
|
I have now added Xarith1(M,MN) and Xarithpm1(M,MN) names to all the relevant groups in the database, and I updated this PR accordingly. Note that X_1(2,2N) will be displayed as X_1(2,2N) rather than X_{arith,1}(2,2N) but will be included in the X_{arith,1}(2,2N) family, and similarly for X_{+/-1}(2,2N). If we decide we want to change this, it can be done in the data without changing the code, so it isn't really relevant to this PR, which I'm happy to merge once the two small issues below are fixed:
|
|
Thank you for catching that - I have fixed the two small issues! |
|
Great! I will merge this once tests pass. |
We created family pages for the families of modular curves on the lmfdb.