Skip to content

Conversation

@asiminah
Copy link
Contributor

We created family pages for the families of modular curves on the lmfdb.

@roed314
Copy link
Member

roed314 commented Jan 14, 2025

This is now up on https://blue.lmfdb.xyz/ModularCurve/Q/ if anyone wants to take a look.

@roed314
Copy link
Member

roed314 commented Jan 20, 2025

The test failure now is probably due to a data change in local fields and not your fault. @jwj61 are you able to take a look?

@jwj61
Copy link
Member

jwj61 commented Jan 20, 2025

Actually, the problem is that including the Galois group is now broken for padic fields. I noticed this earlier today and was going to look at it tomorrow anyway.

@jwj61
Copy link
Member

jwj61 commented Jan 20, 2025

Yes, it is a data problem (and my fault). Rewrite in progress.

@jwj61
Copy link
Member

jwj61 commented Jan 20, 2025

Should be fixed now.

On a tangentially related note, we currently have columns gal and galT which are exactly the same. I suggest deleting galT after removing it from the code (it is easy to search for the few instances of galT). Objections?

@roed314
Copy link
Member

roed314 commented Jan 20, 2025

I certainly agree on dropping the column eventually, but I would wait until everything gets updated to not use the old column (the main thing that breaks color branches is dropping columns).

@AndrewVSutherland
Copy link
Member

AndrewVSutherland commented Feb 23, 2025

Apologies for the delay in reviewing this, I noticed a few issues.

Small things:

  • bi-elliptic needs a knowl
  • I think we should omit the remarks section whn both are unknown
  • In the remarks section I think claims of the form "There are only * hyperelliptic/bi-elliptic curves." should instead say "There are only * hyperelliptic/bi-elliptic curves in this family."
  • On http://127.0.0.1:37777/ModularCurve/Q/family/XS4 the $\ell$ in the first line should be $p$.
  • On http://127.0.0.1:37777/ModularCurve/Q/family/Xarithpm1 I would move the +/-1 to the upper left corner to match X_{+/-1}(N); this will still define the same group.

Big things:

  • The moduli descriptions of X_{arith,1}(M,MN) and X_{arith,+/-1}(M,MN) are incorrect, the current language descirbes X_1(M,MN) and X_{+/-1}(M,MN); the "arith" versions of these curves have canoncial field of definition Q for all M and N (that is the whole point of the "arith"), and are included in the LMFDB for all MN <= 70, e.g. X_{arith,1}(3,15) is 15.576.9-15.a.2.1 (this isn't obvious from staring at the generators, but you can conjugate them to match). For the moduli interpretation of the arith version, note that if you project to level M you get X_arith(M), so really you have point of order MN and an independent cyclic subgroup of order M.
  • X_{+/-1}(3,3N) also has canonical field of definition Q and these curves are in the database, e.g. X_{+/-1}(3,15) is 15.576.9-15.a.2.4 note this is not the same curve as X_{arith,1}(3,15) or X_{arith,+/-1)(3,15) (the later of which is 15.288.9.a.2.

We should decide whether we want to have separate families for X_1(M,MN) (which would only be relevant for M=2) and X_{arith,1}(M,MN), and similarly for X_{+/-1}(M,MN) (which would only be relevant for M =2,3) and X_{arith,+/-1}(M,MN).

Let's discuss this on the LMFDB modular curves Zulip.

EDIT: When kicking off that discussion I realized that I think we should not have separate families for X_1(M,MN) and X_{+/-1}(M,MN), the curves that are present (under our surjective determinant constraint) will show up in the arith families anyway, but I do think we should label them without the "arith" when it is not needed (as we do with X(2) in the X_arith(N) family).

@AndrewVSutherland
Copy link
Member

It looks like you give the correct moduli description for X_{arith,1}(M,MN) and X_{arith,+/-1}(M,MN) in your paper arXiv:2501.10883, you should just make the pages in this PR match your paper :)

@junbolau
Copy link
Contributor

We addressed the minor issues above. We will wait for the Zulip discussion to mature before we make edits on the major issue.

update parse_family to use new Xarith1 and Xarithpm1 names
@AndrewVSutherland
Copy link
Member

I have now added Xarith1(M,MN) and Xarithpm1(M,MN) names to all the relevant groups in the database, and I updated this PR accordingly. Note that X_1(2,2N) will be displayed as X_1(2,2N) rather than X_{arith,1}(2,2N) but will be included in the X_{arith,1}(2,2N) family, and similarly for X_{+/-1}(2,2N). If we decide we want to change this, it can be done in the data without changing the code, so it isn't really relevant to this PR, which I'm happy to merge once the two small issues below are fixed:

@asiminah
Copy link
Contributor Author

asiminah commented Mar 1, 2025

Thank you for catching that - I have fixed the two small issues!

@AndrewVSutherland
Copy link
Member

Great! I will merge this once tests pass.

@AndrewVSutherland AndrewVSutherland merged commit 226357e into LMFDB:main Mar 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants