updated BMF browse page field lists after new data added #6356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'll see about fixing the broken test shortly |
Merged
Member
|
It looks like we still need to copy data to proddb, based on the difference in counts on https://beta.lmfdb.org/ModularForm/GL2/ImaginaryQuadratic/ I can take care of this today, but which tables need to be copied, is it just |
Member
Author
|
I did list the 3 relevant tables on some issue or PR. bmf_firms, bmf_dims, ec_nfcurves. All have a lot of extra data. Thanks. |
Member
|
Done! |
Member
Author
|
Great, thanks. When this PR is on prod then things like this https://www.lmfdb.org/ModularForm/GL2/ImaginaryQuadratic/2.0.2199.1/4.2/a/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the fields displayed on the BMF main browse page to reflect the extra data recently added (now on beta, not yet on prod). Instead of ending the lists with ... I added at the end (after the ...) the last relevant field. This is 2.0.2495.1 for dimension data but 2.0.2491.1 for newforms, since the actual last field (2.0.2495.1) has no rational newforms in the level range computed so far.
It would be possible to use db.bmf_dims.max('field_absdisc') and db.bmf_forms.min('field_disc') instead of hard-coding these in python (and until now I had not noticed the inconsistency in these column names and contents!) but I have no plans to compute any BMFs for fields of larger discriminant. [Strictly speaking I have put in dims for 2.0.2683.1 as well as that is the last field of class number 1-5, but there are no rational newforms there anyway in the small range so far computed.]
When this is merged I will update the relevant knowls.
This PR is independent of #6353 .