Update code.yaml #6756
Merged
Update code.yaml #6756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“In elliptic_curves/code.yaml, replace Ser(mfcoefs(mf,20),q) by Ser(ellqexp(E,20),q) and remove duplicate L1:. Please run the snippet generator to refresh GP logs.”
Contributor
|
This is supposed to fix issue #6760 |
assaferan
suggested changes
Nov 7, 2025
Contributor
assaferan
left a comment
assaferan
left a comment
There was a problem hiding this comment.
The change in q-expansion does not seem to work - no such function ellqexp. One can remove the creation of a series from modular form coefficients, and be satisfied with just Ser(ellan(E,20),q)*q.
Also, white spaces again.
…urves elliptic_cuerves/code.yaml EC elliptic_curves/code.yaml: fix PARI q-expansion to Ser(ellan(E,20),q)*q (drop mffromell/mfcoefs/ellqexp), remove duplicate L1 block, and normalize whitespace.
…urves Whitespace issue
…urves whitespace issue
…urves whitespace issue
assaferan
suggested changes
Nov 10, 2025
Contributor
assaferan
left a comment
assaferan
left a comment
There was a problem hiding this comment.
Why are we removing the code snippet for the special value of the L-function?
I think we want to keep it.
Contributor
Author
Because I think there are 2 L function definition on the line 155 and on the line 200 in the original code. But I keep both now. |
assaferan
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use Ser(ellqexp(E,20),q) for PARI q-expansion; clean up L1
YAML fixed; please run snippet generator to refresh GP logs