Update code.yaml #6758
Merged
Update code.yaml #6758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GP: nfsubfields slice fixed (L[2..length(L)], not length(b)). Oscar: Avoid non-portable API: Replaced uppercase PolynomialRing/NumberField with lowercase polynomial_ring/number_field. automorphisms(K) now uses a fallback: isdefined(Main,:automorphisms) ? automorphisms(K) : Hecke.hom(K,K). Guarded transitive_group_identification(G) with degree(K) > 1. Fixed root discriminant to compute from discriminant(ring_of_integers(K)) (no stray dK). Class number formula block uses the lowercase API consistently.
Member
|
Why are there so many whitespace changes? Are they an accident, or are they an improvement? |
Contributor
Author
I copy and paste them locally. That’s why. |
Contributor
|
This is supposed to resolve #6759 |
assaferan
suggested changes
Nov 7, 2025
Contributor
assaferan
left a comment
assaferan
left a comment
There was a problem hiding this comment.
This seems to fix the errors with number fields in Oscar. Please fix the white spaces issues.
solve whitespace issue
whitespace issue
whitespace issue
whitespace issue finally
assaferan
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GP: nfsubfields slice fixed (L[2..length(L)], not length(b)).
Oscar: Avoid non-portable API:
Replaced uppercase PolynomialRing/NumberField with lowercase polynomial_ring/number_field.
automorphisms(K) now uses a fallback: isdefined(Main,:automorphisms) ? automorphisms(K) : Hecke.hom(K,K).
Guarded transitive_group_identification(G) with degree(K) > 1.
Fixed root discriminant to compute from discriminant(ring_of_integers(K)) (no stray dK).
Class number formula block uses the lowercase API consistently.