#6696 lmfdb/abvar/fq/isog_class.py #6770
Closed
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend AbvarFq_isoclass.__init__ to handle new invariants:
Default is_cyclic to None if missing.
Default noncyclic_primes to [] if missing.
In AbvarFq_isoclass.properties:
Append a row "Cyclic" with value "yes" / "no" when is_cyclic is present.
Append a row "Noncyclic primes" showing the stored list (rendered as {p1, p2, …} or {} if empty).
* Extend AbvarFq_isoclass.__init__ to handle new invariants:
* Default is_cyclic to None if missing.
* Default noncyclic_primes to [] if missing.
* In AbvarFq_isoclass.properties:
* Append a row "Cyclic" with value "yes" / "no" when is_cyclic is present.
* Append a row "Noncyclic primes" showing the stored list (rendered as {p1, p2, …} or {} if empty).
* No changes to existing behaviour when the new fields are absent in the database (backwards compatible with old data).
New: solve an issue that causes problems in test_av
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend AbvarFq_isoclass.init to handle new invariants:
Default is_cyclic to None if missing.
Default noncyclic_primes to [] if missing.
In AbvarFq_isoclass.properties:
Append a row "Cyclic" with value "yes" / "no" when is_cyclic is present.
Append a row "Noncyclic primes" showing the stored list (rendered as {p1, p2, …} or {} if empty).