Skip to content

Conversation

@hgu2699
Copy link
Contributor

@hgu2699 hgu2699 commented Nov 16, 2025

This PR adds support for viewing and searching the cyclicity of the group of points for isogeny classes of abelian varieties over finite fields.

Main changes

  • lmfdb/abvar/fq/isog_class.py

    • Extend AbvarFq_isoclass to include:
      • is_cyclic (whether the group of points is cyclic)
      • noncyclic_primes (primes where the isotypic components are non-cyclic)
    • Expose this information on the AV/Fq isogeny class page via properties(), under:
      • “Cyclic group of points”
      • “Non-cyclic primes”
  • lmfdb/abvar/fq/main.py

    • (If applicable in your branch) add/adjust search options and columns so that the new invariants can be queried and, where relevant, shown in the browse/search results.
  • lmfdb/abvar/fq/test_av.py

    • Update test_cyclic_group_of_points_display so it checks for the new “Cyclic group of points” text and passes with the updated display.
  • lmfdb/abvar/fq/test_browse_page.py

    • (If you modified it) add/adjust tests to ensure the new search options and columns behave as expected.

Testing

All tests in the AV/Fq module pass locally:

sage -python -m pytest lmfdb/abvar/fq

@assaferan assaferan requested a review from roed314 November 21, 2025 14:55
Copy link
Member

@roed314 roed314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Let me know if you have any questions about these suggestions.

@hgu2699 hgu2699 requested a review from roed314 November 24, 2025 00:27
Copy link
Member

@roed314 roed314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better; now we mostly just need the knowls.

@roed314
Copy link
Member

roed314 commented Nov 26, 2025

I'm happy with this PR now. @AndrewVSutherland, if you agree with my changes to the knowls (https://beta.lmfdb.org/knowledge/show/av.fq.cyclic_group_points and https://beta.lmfdb.org/knowledge/show/av.fq.noncyclic_primes), feel free to merge this.

@AndrewVSutherland AndrewVSutherland merged commit 6b61ac3 into LMFDB:main Nov 26, 2025
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants