-
Notifications
You must be signed in to change notification settings - Fork 227
Add cyclic isogeny invariants, search options, and tests for AV/Fq Issue #6696 #6772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cyclic isogeny invariants, search options, and tests for AV/Fq Issue #6696 #6772
Conversation
roed314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start! Let me know if you have any questions about these suggestions.
roed314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better; now we mostly just need the knowls.
|
I'm happy with this PR now. @AndrewVSutherland, if you agree with my changes to the knowls (https://beta.lmfdb.org/knowledge/show/av.fq.cyclic_group_points and https://beta.lmfdb.org/knowledge/show/av.fq.noncyclic_primes), feel free to merge this. |
This PR adds support for viewing and searching the cyclicity of the group of points for isogeny classes of abelian varieties over finite fields.
Main changes
lmfdb/abvar/fq/isog_class.pyAbvarFq_isoclassto include:is_cyclic(whether the group of points is cyclic)noncyclic_primes(primes where the isotypic components are non-cyclic)properties(), under:lmfdb/abvar/fq/main.pylmfdb/abvar/fq/test_av.pytest_cyclic_group_of_points_displayso it checks for the new “Cyclic group of points” text and passes with the updated display.lmfdb/abvar/fq/test_browse_page.pyTesting
All tests in the AV/Fq module pass locally: